Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more integration test for parquet bloom filter round trip tests #3210

Merged
merged 2 commits into from
Dec 29, 2022

Conversation

jimexist
Copy link
Member

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@jimexist jimexist marked this pull request as draft November 28, 2022 12:44
@github-actions github-actions bot added the parquet Changes to the parquet crate label Nov 28, 2022
@jimexist jimexist changed the title WIP add more integration test for parquet bloom filter round trip tests add more integration test for parquet bloom filter round trip tests Dec 26, 2022
@jimexist jimexist marked this pull request as ready for review December 26, 2022 12:44
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jimexist

I also double checked the new test runs in CI correctly and in a reasonable amount of time:

https://github.com/apache/arrow-rs/actions/runs/3781373365/jobs/6428207049

============================= test session starts ==============================
platform linux -- Python 3.10.9, pytest-7.2.0, pluggy-1.0.0 -- /opt/hostedtoolcache/Python/3.10.9/x64/bin/python
cachedir: .pytest_cache
rootdir: /home/runner/work/arrow-rs/arrow-rs/parquet/pytest
collecting ... collected 4 items

test_parquet_integration.py::TestParquetIntegration::test_pyspark_bloom_filter[1] PASSED [ 25%]
test_parquet_integration.py::TestParquetIntegration::test_pyspark_bloom_filter[10] PASSED [ 50%]
test_parquet_integration.py::TestParquetIntegration::test_bloom_filter_round_trip[1] PASSED [ 75%]
test_parquet_integration.py::TestParquetIntegration::test_bloom_filter_round_trip[10] PASSED [100%]

👍

@alamb alamb merged commit 99a20dd into apache:master Dec 29, 2022
@ursabot
Copy link

ursabot commented Dec 29, 2022

Benchmark runs are scheduled for baseline = 513d543 and contender = 99a20dd. 99a20dd is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants