Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat DecimalArray as PrimitiveArray in row format #2866

Merged
merged 4 commits into from
Oct 18, 2022

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Follow on to #2857

Rationale for this change

Now that DecimalArray is just a PrimitiveArray, we can simplify the logic for the row format

What changes are included in this PR?

Changes the row format to no longer special-case decimals, and adds tests

Are there any user-facing changes?

No

@github-actions github-actions bot added the arrow Changes to the arrow crate label Oct 13, 2022
@tustvold
Copy link
Contributor Author

This is currently failing tests due to #2873

@@ -811,6 +809,64 @@ mod tests {
}
}

#[test]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tustvold tustvold merged commit 07024f6 into apache:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants