Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Fix clippy for rust 1.64.0 #2771

Merged
merged 1 commit into from
Sep 22, 2022
Merged

MINOR: Fix clippy for rust 1.64.0 #2771

merged 1 commit into from
Sep 22, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Sep 22, 2022

Which issue does this PR close?

Rationale for this change

Fixing a clippy error for rust 1.64.0 in CI:

error: this expression borrows a value the compiler would automatically borrow
   --> arrow-buffer/src/util/bit_chunk_iterator.rs:181:5
    |
181 |     (&mut buf[..len]).copy_from_slice(input);
    |     ^^^^^^^^^^^^^^^^^ help: change this to: `buf[..len]`
    |
    = note: `-D clippy::needless-borrow` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

What changes are included in this PR?

Are there any user-facing changes?

@viirya
Copy link
Member Author

viirya commented Sep 22, 2022

cc @tustvold @sunchao

@viirya viirya merged commit c2972c1 into apache:master Sep 22, 2022
@viirya
Copy link
Member Author

viirya commented Sep 22, 2022

Thanks.

@viirya viirya deleted the clippy_fix branch September 22, 2022 18:47
@ursabot
Copy link

ursabot commented Sep 22, 2022

Benchmark runs are scheduled for baseline = 9833d29 and contender = c2972c1. c2972c1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@tustvold tustvold added the development-process Related to development process of arrow-rs label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants