-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overflow-checking variants of arithmetic dyn kernels #2740
Merged
tustvold
merged 17 commits into
apache:master
from
viirya:arithmetic_checked_dyn_kernels
Sep 20, 2022
Merged
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0c05bab
Init
viirya ac376a1
More
viirya 7f570d1
More
viirya 97c7094
Add tests
viirya 90b3b45
Merge remote-tracking branch 'upstream/master' into arithmetic_checke…
viirya 9d526c9
Fix clippy
viirya 04066c0
Remove macro
viirya c69c48b
Update doc
viirya dc6077f
Fix clippy
viirya 83dcff1
Remove length check
viirya 0be33e0
Merge remote-tracking branch 'upstream/master' into arithmetic_checke…
viirya 4394ff1
Tweak try_binary to coordinate latest optimization
viirya 0f8a5bb
Fix clippy
viirya d81924e
Use for loop
viirya 4eb0fe4
Split non-null variant into never inline function
viirya 38de665
Add value type check
viirya 4d06826
Multiply by get_byte_width of output type.
viirya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the point of the dyn indirection here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to return a
Option<&[Self::Item]>
directly as the semantics look weird (i.e. someArrayAccessor
doesn't providevalues
). This is to return self asArrayValuesAccessor
so the caller can callvalues
.But I think I will remove it based on #2740 (comment).