Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update environment variable name for amazonS3builder in integration (#2550) #2553

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

amrltqt
Copy link
Contributor

@amrltqt amrltqt commented Aug 22, 2022

Which issue does this PR close?

Closes #2550

Rationale for this change

Update the environment variables names injected in the integration pipeline to test AmazonS3 client. The objective is to avoid conflicts when testing real injection while testing AmazonS3Builder::from_env() function.

What changes are included in this PR?

Update the github workflow pipeline + integration tests to leverage new names.

Are there any user-facing changes?

No

@github-actions github-actions bot added the object-store Object Store Interface label Aug 22, 2022
@amrltqt
Copy link
Contributor Author

amrltqt commented Aug 22, 2022

@tustvold it seems that AWS_* are useful as an environment variable for the CI. At least to work with localstack.

I'm starting to think that anyway we will need those variable in the CI, so we can just reuse them as is for testing the environment.

What do you think about it?

@tustvold
Copy link
Contributor

tustvold commented Aug 22, 2022

I'm not sure I follow what you mean, and the CI seems to currently be failing? Do you mean the environment variables are needed for the CLI bootstrap, if so you can set environment variables for specific steps

@amrltqt
Copy link
Contributor Author

amrltqt commented Aug 22, 2022

Yes, I understand that we need (at least) the key_id, the secret_key correctly setup for the CLI to execute aws --endpoint-url=http://localstack:4566 s3 mb s3://test-bucket.

But, it's seems to be not needed anymore after that. I'll try to setup environment by steps as you mention.

@amrltqt
Copy link
Contributor Author

amrltqt commented Aug 22, 2022

@tustvold it should be better now.
Sorry for not having put a draft tag on this PR at first 😅

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@tustvold tustvold merged commit 67579a1 into apache:master Aug 23, 2022
@ursabot
Copy link

ursabot commented Aug 23, 2022

Benchmark runs are scheduled for baseline = 0771b01 and contender = 67579a1. 67579a1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

object_store: use different AWS environment variable name in integration
3 participants