Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More record skipping fuzz tests #2505

Merged
merged 1 commit into from
Aug 20, 2022
Merged

More record skipping fuzz tests #2505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions parquet/src/arrow/arrow_reader/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,6 @@ pub(crate) fn evaluate_predicate(

#[cfg(test)]
mod tests {
use bytes::Bytes;
use std::cmp::min;
use std::collections::VecDeque;
use std::fmt::Formatter;
Expand All @@ -604,6 +603,7 @@ mod tests {
use std::path::PathBuf;
use std::sync::Arc;

use bytes::Bytes;
use rand::{thread_rng, Rng, RngCore};
use tempfile::tempfile;

Expand Down Expand Up @@ -1289,12 +1289,19 @@ mod tests {
// Test with nulls and row filter
TestOptions::new(2, 256, 93)
.with_null_percent(25)
.with_max_data_page_size(10)
.with_row_filter(),
// Test with nulls and row filter
// Test with nulls and row filter and small pages
TestOptions::new(2, 256, 93)
.with_null_percent(25)
.with_max_data_page_size(10)
.with_row_selections()
.with_row_filter(),
// Test with row selection and no offset index and small pages
TestOptions::new(2, 256, 93)
.with_enabled_statistics(EnabledStatistics::None)
.with_max_data_page_size(10)
.with_row_selections(),
];

all_options.into_iter().for_each(|opts| {
Expand Down Expand Up @@ -1407,7 +1414,6 @@ mod tests {

file.rewind().unwrap();

// TODO: Should be able to always enable page index (#2434)
let options = ArrowReaderOptions::new()
.with_page_index(opts.enabled_statistics == EnabledStatistics::Page);

Expand Down