Make Parquet reader filter APIs public (#1792) #2467
Conversation
There was a problem hiding this comment.
FYI @Ted-Jiang @thinkharderdev @viirya and @HaoYang670
This is quite exciting and represents a big step forward for the rust parquet implementation 🎉
| @@ -398,11 +398,11 @@ mod tests { | |||
| let mut rand = thread_rng(); | |||
| for _ in 0..100 { | |||
| let a_len = rand.gen_range(10..100); | |||
| let a_bools: Vec<_> = (0..a_len).map(|x| rand.gen_bool(0.2)).collect(); | |||
| let a_bools: Vec<_> = (0..a_len).map(|_| rand.gen_bool(0.2)).collect(); | |||
There was a problem hiding this comment.
seems random that this started getting flagged by clippy 🤷 -- I suppose I am always one for a good drive by cleanup anyways 🚗
There was a problem hiding this comment.
It is because the unused suppression at the module level was removed
alamb
changed the title
Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
|
Benchmark runs are scheduled for baseline = 0013170 and contender = 6d0ea90. 6d0ea90 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Part of #1792
Rationale for this change
There is still more work to be done in this space, but I am confident that this functionality is sufficiently mature that we can expose it and start to get feedback from the wild
What changes are included in this PR?
Makes the crate-private row filtering APIs, public
Are there any user-facing changes?