Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refine validation for decimal128 array #2428

Merged
merged 1 commit into from
Aug 12, 2022
Merged

refactor: refine validation for decimal128 array #2428

merged 1 commit into from
Aug 12, 2022

Conversation

liukun4515
Copy link
Contributor

Which issue does this PR close?

follow up of #2360

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 12, 2022
@liukun4515 liukun4515 marked this pull request as ready for review August 12, 2022 10:45
@liukun4515
Copy link
Contributor Author

Benchmark result:
before this refactor:

validate_decimal128_array 20000
                        time:   [56.566 us 56.867 us 57.195 us]
                        change: [-0.7933% -0.1263% +0.5894%] (p = 0.72 > 0.05)
                        No change in performance detected.
Found 7 outliers among 100 measurements (7.00%)
  6 (6.00%) high mild
  1 (1.00%) high severe

After this refactor:

validate_decimal128_array 20000
                        time:   [34.534 us 34.711 us 34.895 us]
                        change: [-39.461% -39.030% -38.571%] (p = 0.00 < 0.05)
                        Performance has improved.

The performance improves about 40%

liukun4515
liukun4515 commented Aug 12, 2022
View reviewed changes
arrow/src/array/builder/decimal_builder.rs
self.builder.append_value(value_as_bytes.as_slice())
}

pub(crate) fn from_i128_to_fixed_size_bytes(v: i128, size: usize) -> Result<Vec<u8>> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use https://doc.rust-lang.org/std/primitive.i128.html#method.to_le_bytes directly

@liukun4515 liukun4515 force-pushed the optimize_decimal128_validation branch from 79b6f21 to 7e36967 Compare August 12, 2022 10:51
@tustvold tustvold merged commit 0e97491 into apache:master Aug 12, 2022
@tustvold
Copy link
Contributor

Merging as integration test failure is unrelated

@ursabot
Copy link

ursabot commented Aug 12, 2022

Benchmark runs are scheduled for baseline = ee2818e and contender = 0e97491. 0e97491 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liukun4515 @tustvold @ursabot