Fix parquet clippy lints (#1254) #2377
Conversation
| @@ -229,88 +223,3 @@ impl<I: Iterator<Item = Vec<Page>> + Send> PageIterator for InMemoryPageIterator | |||
| Ok(self.column_desc.clone()) | |||
| } | |||
| } | |||
|
|
|||
| pub fn make_pages<T: DataType>( | |||
There was a problem hiding this comment.
This is moved to rand_gen, as it made the conditional compilation easier
| @@ -142,12 +142,14 @@ impl LevelEncoder { | |||
| /// Decoder for definition/repetition levels. | |||
| /// Currently only supports RLE and BIT_PACKED encoding for Data Page v1 and | |||
| /// RLE for Data Page v2. | |||
| #[allow(unused)] | |||
There was a problem hiding this comment.
Interestingly this is never actually used anywhere 😅
| use std::sync::Arc; | ||
|
|
||
| use crate::errors::Result; | ||
| use std::marker::PhantomData; | ||
|
|
||
| #[cfg(test)] |
There was a problem hiding this comment.
This is kind of gross, but I hope to remove this module eventually #1661
| ) -> Self { | ||
| Self { | ||
| key_reader, | ||
| value_reader, | ||
| data_type, | ||
| map_def_level: rep_level, | ||
| map_rep_level: def_level, |
There was a problem hiding this comment.
I don't think this is correct, but changing it caused the tests to fail...
|
Benchmark runs are scheduled for baseline = 613b99d and contender = 80a6ef7. 80a6ef7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Can drop this after rebase on commit 80a6ef7 "Fix parquet clippy lints (apache#1254) (apache#2377)", first released in 21.0.0
Can drop this after rebase on commit 80a6ef7 "Fix parquet clippy lints (apache#1254) (apache#2377)", first released in 21.0.0
Can drop this after rebase on commit 80a6ef7 "Fix parquet clippy lints (apache#1254) (apache#2377)", first released in 21.0.0
Can drop this after rebase on commit 80a6ef7 "Fix parquet clippy lints (apache#1254) (apache#2377)", first released in 21.0.0
Which issue does this PR close?
Closes #1254
Rationale for this change
Clippy generally has good advice
What changes are included in this PR?
This fixes a number of the clippy lints, with localised suppression in the cases where fixing would result in a breaking API change
Are there any user-facing changes?
No