Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for skip_values in DictionaryDecoder and fix it #2105

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

Ted-Jiang
Copy link
Member

Which issue does this PR close?

Related #2079

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Jul 19, 2022
@@ -346,6 +346,7 @@ where
// Keys will be validated on conversion to arrow
let keys_slice = keys.spare_capacity_mut(range.start + len);
let len = decoder.get_batch(&mut keys_slice[range.start..])?;
*max_remaining_values -= len;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss this will fail at record skip count.

@codecov-commenter
Copy link

Codecov Report

Merging #2105 (0c7cfb5) into master (2541e2c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2105      +/-   ##
==========================================
+ Coverage   83.73%   83.74%   +0.01%     
==========================================
  Files         225      225              
  Lines       59412    59458      +46     
==========================================
+ Hits        49748    49796      +48     
+ Misses       9664     9662       -2     
Impacted Files Coverage Δ
...et/src/arrow/array_reader/byte_array_dictionary.rs 86.97% <100.00%> (+2.51%) ⬆️
arrow/src/datatypes/datatype.rs 64.05% <0.00%> (-0.36%) ⬇️
parquet/src/encodings/rle.rs 92.78% <0.00%> (+0.19%) ⬆️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2541e2c...0c7cfb5. Read the comment docs.


let valid = vec![true, true, true, true, true];
let valid_buffer = Buffer::from_iter(valid.iter().cloned());
output.pad_nulls(0, 5, 5, valid_buffer.as_slice());
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tustvold i found without pad_nulls then call into_array will return empty.
Is there other way to change into array without padding🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, call BufferQueue::set_len, which is what RecordReader will do

@tustvold tustvold merged commit 3096591 into apache:master Jul 20, 2022
@ursabot
Copy link

ursabot commented Jul 20, 2022

Benchmark runs are scheduled for baseline = 8d7e2ae and contender = 3096591. 3096591 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants