Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dictionary support to subtract_scalar, multiply_scalar, divide_scalar #2020

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Jul 7, 2022

Which issue does this PR close?

Closes #2019.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jul 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2020 (2647312) into master (62053a8) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 2647312 differs from pull request most recent head ffd4b54. Consider uploading reports for the commit ffd4b54 to get more accurate results

@@            Coverage Diff             @@
##           master    #2020      +/-   ##
==========================================
+ Coverage   83.58%   83.62%   +0.03%     
==========================================
  Files         222      222              
  Lines       57639    57763     +124     
==========================================
+ Hits        48180    48303     +123     
- Misses       9459     9460       +1     
Impacted Files Coverage Δ
arrow/src/compute/kernels/arithmetic.rs 93.39% <100.00%> (+1.43%) ⬆️
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62053a8...ffd4b54. Read the comment docs.

@viirya
Copy link
Member Author

viirya commented Jul 7, 2022

cc @sunchao

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viirya
Copy link
Member Author

viirya commented Jul 7, 2022

Thanks @sunchao

@viirya viirya merged commit da3879e into apache:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DataType::Dictionary support to subtract_scalar, multiply_scalar, divide_scalar
3 participants