Fix decimals min max statistics #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
reviewed
Apr 26, 2022
viirya
reviewed
Apr 26, 2022
viirya
reviewed
Apr 26, 2022
viirya
reviewed
Apr 26, 2022
|
Hi @viirya, could you please help to trigger the CI processes? Thank you! |
viirya
reviewed
Apr 27, 2022
sunchao
reviewed
Apr 28, 2022
sunchao
reviewed
Apr 28, 2022
viirya
reviewed
Apr 28, 2022
viirya
reviewed
Apr 28, 2022
viirya
reviewed
Apr 28, 2022
viirya
approved these changes
Apr 28, 2022
|
I will merge this after CI passes. |
|
I will hold off on making the 13.0.0 release candidate to include this fix |
|
Since the MIRI test takes a while to run (and it will run again on the branch prior to release) I am going to merge this PR in even before it is complete so I can make the release candidate. 🚀 |
|
Thanks @viirya and @atefsawaed |
|
Thanks @alamb @atefsawaed @sunchao @HaoYang670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1532.
Rationale for this change
What changes are included in this PR?
Added a suitable comparator for Decimals that are built with byte arrays.
Are there any user-facing changes?
No.