Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map nullable flag in ParquetTypeConverter #1592

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Apr 20, 2022

Which issue does this PR close?

Closes #1587.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Apr 20, 2022
@@ -1018,7 +1018,7 @@ impl ParquetTypeConverter<'_> {
Box::new(Field::new(
key_item.name(),
DataType::Struct(vec![key, value]),
false,
self.schema.is_optional(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to previous inconsistency I described in the ticket, I changed this to follow visit_map.

@codecov-commenter
Copy link

Codecov Report

Merging #1592 (bc0cb98) into master (db4cb8f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head bc0cb98 differs from pull request most recent head 380ba0a. Consider uploading reports for the commit 380ba0a to get more accurate results

@@            Coverage Diff             @@
##           master    #1592      +/-   ##
==========================================
+ Coverage   82.93%   82.95%   +0.01%     
==========================================
  Files         193      193              
  Lines       55350    55376      +26     
==========================================
+ Hits        45907    45939      +32     
+ Misses       9443     9437       -6     
Impacted Files Coverage Δ
arrow/src/compute/kernels/substring.rs 100.00% <100.00%> (+1.68%) ⬆️
parquet/src/arrow/schema.rs 86.08% <100.00%> (+0.24%) ⬆️
arrow/src/array/transform/mod.rs 86.57% <0.00%> (+0.22%) ⬆️
parquet_derive/src/parquet_field.rs 66.43% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db4cb8f...380ba0a. Read the comment docs.

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed this aligns with the specification - https://github.com/apache/parquet-format/blob/master/LogicalTypes.md

@viirya
Copy link
Member Author

viirya commented Apr 20, 2022

Thank you @tustvold for confirming it.

@tustvold tustvold merged commit fd9cb23 into apache:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect nullable flag when reading maps ( test_read_maps fails when force_validate is active)
3 participants