Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Clone and PartialEq for json DecoderOptions #1581

Merged
merged 2 commits into from
Apr 18, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Apr 17, 2022

Which issue does this PR close?

Closes #1580

Rationale for this change

see ticket

What changes are included in this PR?

derive Clone and PartialEq, test

Are there any user-facing changes?

yes

@github-actions github-actions bot added the arrow Changes to the arrow crate label Apr 17, 2022
@alamb alamb changed the title Alamb/options clone Derive Clone and PartialEq for json DecoderOptions Apr 17, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1581 (04bc93e) into master (dbc47e0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1581      +/-   ##
==========================================
- Coverage   82.87%   82.87%   -0.01%     
==========================================
  Files         193      193              
  Lines       55304    55311       +7     
==========================================
+ Hits        45835    45840       +5     
- Misses       9469     9471       +2     
Impacted Files Coverage Δ
arrow/src/json/reader.rs 84.52% <100.00%> (+0.03%) ⬆️
arrow/src/datatypes/datatype.rs 66.40% <0.00%> (-0.40%) ⬇️
arrow/src/datatypes/field.rs 54.32% <0.00%> (-0.30%) ⬇️
parquet/src/encodings/encoding.rs 93.37% <0.00%> (-0.19%) ⬇️
arrow/src/ipc/reader.rs 88.61% <0.00%> (ø)
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (ø)
arrow/src/compute/kernels/substring.rs 98.31% <0.00%> (ø)
arrow/src/compute/kernels/cast.rs 95.74% <0.00%> (+<0.01%) ⬆️
parquet/src/column/writer.rs 92.42% <0.00%> (+<0.01%) ⬆️
parquet/src/file/properties.rs 95.76% <0.00%> (+0.01%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc47e0...04bc93e. Read the comment docs.

@yjshen yjshen merged commit db4cb8f into apache:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Clone for JSON DecoderOptions
5 participants