Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generate_decimal128_case in integration test #1440

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Mar 14, 2022

Which issue does this PR close?

Closes #1439.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@codecov-commenter
Copy link

Codecov Report

Merging #1440 (ac102ca) into master (729934c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1440      +/-   ##
==========================================
- Coverage   82.67%   82.67%   -0.01%     
==========================================
  Files         185      185              
  Lines       53822    53830       +8     
==========================================
+ Hits        44500    44503       +3     
- Misses       9322     9327       +5     
Impacted Files Coverage Δ
integration-testing/src/lib.rs 0.00% <0.00%> (ø)
arrow/src/array/transform/mod.rs 86.31% <0.00%> (ø)
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (+0.22%) ⬆️
arrow/src/datatypes/field.rs 54.10% <0.00%> (+0.30%) ⬆️
arrow/src/datatypes/datatype.rs 66.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729934c...ac102ca. Read the comment docs.

Copy link
Contributor

@liukun4515 liukun4515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viirya

@viirya
Copy link
Member Author

viirya commented Mar 14, 2022

Thanks @liukun4515 !

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thanks @viirya

@viirya
Copy link
Member Author

viirya commented Mar 14, 2022

Thanks @alamb ! I will continue fixing other integration test failures.

@alamb alamb merged commit 717216f into apache:master Mar 14, 2022
@viirya viirya deleted the generate_decimal128_case branch March 14, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix generate_decimal128_case in integration test
4 participants