Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance if dictionary kernels, add benchmark and add take_iter_unchecked #1372

Merged
merged 3 commits into from
Mar 3, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Mar 1, 2022

Which issue does this PR close?

Closes #1371.

dict eq string          time:   [682.94 us 686.12 us 689.61 us]                                                                                                   
                        change: [-3.5494% -2.4463% -1.3917%] (p = 0.00 < 0.05)                                                                                    
                        Performance has improved.                                                                                                                 
Found 9 outliers among 100 measurements (9.00%)                                                                                                                   
  6 (6.00%) high mild                                                                                                                                             
  3 (3.00%) high severe                                                                                                                                           

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Mar 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2022

Codecov Report

Merging #1372 (4f41726) into master (6ee51bc) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1372      +/-   ##
==========================================
+ Coverage   82.99%   83.02%   +0.03%     
==========================================
  Files         181      181              
  Lines       52933    53020      +87     
==========================================
+ Hits        43932    44022      +90     
+ Misses       9001     8998       -3     
Impacted Files Coverage Δ
arrow/src/compute/kernels/comparison.rs 92.45% <ø> (+0.29%) ⬆️
arrow/src/array/array_binary.rs 93.22% <100.00%> (-0.27%) ⬇️
arrow/src/array/array_boolean.rs 93.18% <100.00%> (-1.44%) ⬇️
arrow/src/array/array_primitive.rs 94.71% <100.00%> (+0.02%) ⬆️
arrow/src/array/array_string.rs 97.65% <100.00%> (+0.01%) ⬆️
arrow/src/datatypes/datatype.rs 66.40% <0.00%> (-0.40%) ⬇️
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.23%) ⬇️
arrow/src/compute/kernels/temporal.rs 97.22% <0.00%> (-0.13%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ee51bc...4f41726. Read the comment docs.

@viirya
Copy link
Member Author

viirya commented Mar 1, 2022

The performance looks a bit better?

cc @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @viirya -- I think this looks 👍

arrow/src/compute/kernels/comparison.rs Show resolved Hide resolved
@alamb alamb changed the title Add benchmark and take_iter_unchecked Improve performance if dictionary kernels, add benchmark and add take_iter_unchecked Mar 2, 2022
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@viirya
Copy link
Member Author

viirya commented Mar 3, 2022

Thank you @alamb !

@alamb
Copy link
Contributor

alamb commented Mar 3, 2022

Thank you @viirya -- sorry I am backed up on reviews and merging. Always so much to do!

@alamb alamb merged commit f9e4cf5 into apache:master Mar 3, 2022
@viirya
Copy link
Member Author

viirya commented Mar 3, 2022

Thank you @alamb again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve performance of compare_dict_op
3 participants