Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bitmask creation also for simd comparisons with scalar #1290

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Fix bitmask creation also for simd comparisons with scalar #1290

merged 1 commit into from
Feb 9, 2022

Conversation

jhorstmann
Copy link
Contributor

Which issue does this PR close?

Closes #1285 (now also for comparisons with a scalar).

Rationale for this change

Followup to #1286, which only fixed the bitmask creation for comparing two arrays, but missed the same bug when comparing with a scalar.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 9, 2022
@jhorstmann
Copy link
Contributor Author

Noticed by @JasonLi-cn and @alamb in 411171a. Sorry again for missing this earlier.

@alamb
Copy link
Contributor

alamb commented Feb 9, 2022

Thanks @jhorstmann -- I'll get this in and spin up a new RC 👍

@jhorstmann
Copy link
Contributor Author

For reference, before the fix tests with the larger inputs tests would fail like this:

---- compute::kernels::comparison::tests::test_primitive_array_eq_scalar stdout ----
thread 'compute::kernels::comparison::tests::test_primitive_array_eq_scalar' panicked at 'assertion failed: `(left == right)`
  left: `BooleanArray
[
  false,
  false,
  true,
  false,
  false,
  false,
  false,
  true,
  false,
  false,
  ...80 elements...,
  false,
  false,
  true,
  false,
  false,
  false,
  false,
  true,
  false,
  false,
]`,
 right: `BooleanArray
[
  false,
  false,
  true,
  true,
  true,
  true,
  true,
  true,
  true,
  true,
  ...80 elements...,
  false,
  false,
  true,
  false,
  false,
  false,
  false,
  true,
  false,
  false,
]`', arrow/src/compute/kernels/comparison.rs:2518:9

@alamb alamb merged commit a049640 into apache:master Feb 9, 2022
alamb referenced this pull request Feb 9, 2022
@jhorstmann @alamb
Fix bitmask creation in chunked part of simd comparison (#1286)
411171a
alamb pushed a commit to alamb/arrow-rs that referenced this pull request Feb 9, 2022
@jhorstmann @alamb
Fix bitmask creation also for simd comparisons with scalar (apache#1290)
ca9d9bb
@alamb alamb mentioned this pull request Feb 9, 2022
Merged
alamb added a commit that referenced this pull request Feb 13, 2022
@alamb @jhorstmann
Changes for 9.0.2 (#1291)
a423d92 
* Fix bitmask creation in chunked part of simd comparison (#1286)

* Update version to 9.0.1

* Update changelog

* Fix bitmask creation also for simd comparisons with scalar (#1290)

* Update versions and changelog for 9.0.2

Co-authored-by: Jörn Horstmann <git@jhorstmann.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mistake in chunked part of comparison kernels
2 participants
@jhorstmann @alamb