Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run rustdoc in CI and error if warnings #1266

Merged
merged 7 commits into from
Feb 8, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Feb 3, 2022

Which issue does this PR close?

Re #1267
closes #232

Rationale for this change

Once we have doc links fixed, ensure they don't get broken again by checking in CI

What changes are included in this PR?

Update the clippy check to also run cargo doc and fail on any warnings

Are there any user-facing changes?

No

@alamb alamb added the development-process Related to development process of arrow-rs label Feb 3, 2022
.github/workflows/rust.yml Outdated Show resolved Hide resolved
.github/workflows/rust.yml Outdated Show resolved Hide resolved
@alamb alamb marked this pull request as draft February 3, 2022 19:25
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #1266 (52581f8) into master (43299cc) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1266      +/-   ##
==========================================
- Coverage   83.02%   83.02%   -0.01%     
==========================================
  Files         180      180              
  Lines       52269    52269              
==========================================
- Hits        43398    43396       -2     
- Misses       8871     8873       +2     
Impacted Files Coverage Δ
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (-0.46%) ⬇️
arrow/src/array/transform/mod.rs 84.64% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43299cc...52581f8. Read the comment docs.

@alamb alamb marked this pull request as ready for review February 7, 2022 14:59
@alamb alamb merged commit c7e36ea into apache:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo doc fails with cannot find function bitwise_bin_op_simd_helper when using features=["simd"]
2 participants