Refresh parquet readme / contributing guide #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Feb 1, 2022
| use std::fs::File; | ||
| use std::path::Path; | ||
| use parquet::file::reader::{FileReader, SerializedFileReader}; | ||
|
|
There was a problem hiding this comment.
This example is row oriented -- I am working on a PR that has some more realistic examples (and will include them on the docs.rs landing page)
|
|
||
| ## Rust Version Compatbility | ||
|
|
||
| This crate is tested with the latest stable version of Rust. We do not currrently test against other, older versions of the Rust compiler. | ||
|
|
||
| ## Supported Parquet Version |
There was a problem hiding this comment.
the supported format is already listed in the features section -- moved this content to contributing guide
alamb
commented
Feb 1, 2022
| @@ -63,11 +37,13 @@ version is available. Then simply update version of `parquet-format` crate in Ca | |||
| - [x] Primitive column value readers | |||
| - [x] Row record reader | |||
| - [x] Arrow record reader | |||
| - [x] Async support (to Arrow) | |||
There was a problem hiding this comment.
assumes #1154 is merged
jimexist
approved these changes
Feb 2, 2022
|
Parquet doc updates: #1253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the repo readme and contributing guide
I am working on a PR to improve the docs.rs page next https://docs.rs/parquet/8.0.0/parquet/