Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick Remove unneeded rc feature of serde to active_release #1016

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 9, 2021

Automatic cherry-pick of 771b248

Fixes #989.

This feature opts into impls for `Rc` and `Arc`, but none of the data
structures that use Serialize/Deserialize actually contain `Rc` or
`Arc`s.

See:

- [Serde docs](https://serde.rs/feature-flags.html#-features-rc)
- [PR adding this](apache/arrow#3016)
@github-actions github-actions bot added the arrow Changes to the arrow crate label Dec 9, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1016 (81951af) into active_release (a92672e) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           active_release    #1016   +/-   ##
===============================================
  Coverage           82.37%   82.38%           
===============================================
  Files                 168      168           
  Lines               49133    49133           
===============================================
+ Hits                40474    40476    +2     
+ Misses               8659     8657    -2     
Impacted Files Coverage Δ
arrow/src/array/transform/mod.rs 85.47% <0.00%> (+0.13%) ⬆️
parquet/src/encodings/encoding.rs 93.71% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a92672e...81951af. Read the comment docs.

@alamb
Copy link
Contributor Author

alamb commented Dec 9, 2021

SIMD checks are failing due to some error in the nightly rust compiler

@alamb alamb merged commit 557fc11 into active_release Dec 9, 2021
@alamb alamb deleted the cherry_pick_771b2481 branch December 9, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants