Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RleValueEncoder::flush_buffer Panics if No Encoded Values #2558

Closed
tustvold opened this issue Aug 23, 2022 · 0 comments · Fixed by #2559
Closed

RleValueEncoder::flush_buffer Panics if No Encoded Values #2558

tustvold opened this issue Aug 23, 2022 · 0 comments · Fixed by #2559
Labels
bug parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

Describe the bug

#2231 added an assertion to verify that length of the buffer on finish. Unfortunately it incorrectly handles the case of no encoded values.

To Reproduce

Write a column containing no values, it will panic with "should have had padding inserted"

Expected behavior

Additional context
@tustvold tustvold added the bug label Aug 23, 2022
@tustvold tustvold changed the title RleValueEncoder Panic if Empty RleValueEncoder Panics if Empty Aug 23, 2022
@tustvold tustvold changed the title RleValueEncoder Panics if Empty RleValueEncoder::flush_buffer Panics if No Encoded Values Aug 23, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 23, 2022
@tustvold
Don't panic on RleValueEncoder::flush_buffer if empty (apache#2558)
1549afa
@tustvold tustvold mentioned this issue Aug 23, 2022
Merged
tustvold added a commit that referenced this issue Aug 23, 2022
@tustvold
Don't panic on RleValueEncoder::flush_buffer if empty (#2558) (#2559)
f11fc1f
@alamb alamb added the object-store Object Store Interface label Sep 1, 2022
@tustvold tustvold added parquet Changes to the parquet crate and removed object-store Object Store Interface labels Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't panic on RleValueEncoder::flush_buffer if empty (#2558) tustvold/arrow-rs
2 participants
@alamb @tustvold