-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode Field and Schema metadata using the same type #2262
Labels
enhancement
Any new improvement worthy of a entry in the changelog
Comments
crepererum
added a commit
to crepererum/arrow-rs
that referenced
this issue
Nov 21, 2022
crepererum
added a commit
to crepererum/arrow-rs
that referenced
this issue
Nov 21, 2022
crepererum
added a commit
to crepererum/arrow-rs
that referenced
this issue
Nov 21, 2022
crepererum
added a commit
to crepererum/arrow-rs
that referenced
this issue
Nov 21, 2022
crepererum
added a commit
to crepererum/arrow-rs
that referenced
this issue
Nov 21, 2022
tustvold
added a commit
that referenced
this issue
Nov 21, 2022
* refactor: convert `Field::metadata` to `HashMap` Closes #2262. * refactor: code formatting Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com> Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Right now, Schema metadata is encoded using
HashMap
and Field metadata is encoded usingBTreeMap
:This is confusing and makes for awkward code.
Describe the solution you'd like
A single unified metadata type for both
Schema
andField
Describe alternatives you've considered
HashMap
orBTreeMap
Option<HashMap>
orOption<BTreeMap>
arrow
specific Metadata type that wraps HashMap / BTreeMap and implements whatever extra behavior might be neededAdditional context
There is quite a bit of discussion on #2261
The text was updated successfully, but these errors were encountered: