Skip to content

Commit

Permalink
Not operator overload for SortOptions (#3727)
Browse files Browse the repository at this point in the history
* Not operator overload for SortOptions

* clippy fail fixed

* Comments are removed

---------

Co-authored-by: Mustafa Akur <106137913+mustafasrepo@users.noreply.github.com>
  • Loading branch information
berkaysynnada and mustafasrepo authored Feb 16, 2023
1 parent 55c598d commit 221533f
Showing 1 changed file with 48 additions and 0 deletions.
48 changes: 48 additions & 0 deletions arrow-schema/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ mod field;
pub use field::*;
mod schema;
pub use schema::*;
use std::ops;

#[cfg(feature = "ffi")]
pub mod ffi;
Expand All @@ -47,3 +48,50 @@ impl Default for SortOptions {
}
}
}

/// `!` operator is overloaded for `SortOptions` to invert boolean
/// fields of the struct.
impl ops::Not for SortOptions {
type Output = SortOptions;

fn not(self) -> SortOptions {
SortOptions {
descending: !self.descending,
nulls_first: !self.nulls_first,
}
}
}

#[test]
fn test_overloaded_not_sort_options() {
let sort_options_array = [
SortOptions {
descending: false,
nulls_first: false,
},
SortOptions {
descending: false,
nulls_first: true,
},
SortOptions {
descending: true,
nulls_first: false,
},
SortOptions {
descending: true,
nulls_first: true,
},
];

assert!((!sort_options_array[0]).descending);
assert!((!sort_options_array[0]).nulls_first);

assert!((!sort_options_array[1]).descending);
assert!(!(!sort_options_array[1]).nulls_first);

assert!(!(!sort_options_array[2]).descending);
assert!((!sort_options_array[2]).nulls_first);

assert!(!(!sort_options_array[3]).descending);
assert!(!(!sort_options_array[3]).nulls_first);
}

0 comments on commit 221533f

Please sign in to comment.