Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Revendor flatcc #592

Merged
merged 5 commits into from
Aug 27, 2024
Merged

feat: Revendor flatcc #592

merged 5 commits into from
Aug 27, 2024

Conversation

bkietz
Copy link
Member

@bkietz bkietz commented Aug 20, 2024

After dvidelabs/flatcc#289 flatcc will not enforce alignment on empty vectors. This will let us unskip the null_trivial case in the integration tests

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think it just need a cmake-format -i CMakeLists.txt and to possibly add flatcc_generated.h to the files we ignore for clang-format in .pre-commit.yaml.

@bkietz
Copy link
Member Author

bkietz commented Aug 21, 2024

to possibly add flatcc_generated.h to the files we ignore

It is already excluded, and everything in thirdparty/ too. However the CI job uses --all-files which overrides exclusions. This seems to have been the case since pre-commit was added to the project, so I assume we want to remove that flag now

@paleolimbot
Copy link
Member

--all-files which overrides exclusions

This is not true for me locally (e.g., if I remove thirdparty/ then all of flatcc becomes reformatted when I run pre-commit run --all-files), but other than this and ADBC I am not all that familiar with the details. We could also just reformat it as part of the vendoring if it causes too much trouble.

@bkietz bkietz merged commit 3298ebc into apache:main Aug 27, 2024
34 checks passed
@bkietz bkietz deleted the revendor-flatcc branch August 27, 2024 16:16
@paleolimbot paleolimbot added this to the nanoarrow 0.6.0 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants