Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Silence warning when compiling nanoarrow.hpp on at least one version of MSVC #590

Merged
merged 2 commits into from
Aug 19, 2024
Merged

fix: Silence warning when compiling nanoarrow.hpp on at least one version of MSVC #590

merged 2 commits into from
Aug 19, 2024

Conversation

paleolimbot
Copy link
Member

Encountered in an ADBC build:

https://github.com/apache/arrow-adbc/actions/runs/10424783996/job/28874300812#step:10:830

D:\a\arrow-adbc\arrow-adbc\adbc\c\vendor\nanoarrow\nanoarrow.hpp(829,21): warning C4355: 'this': used in base member initializer list [D:\a\arrow-adbc\arrow-adbc\adbc\build\driver\framework\adbc_driver_framework.vcxproj]

@paleolimbot paleolimbot marked this pull request as ready for review August 19, 2024 13:27
@paleolimbot paleolimbot merged commit 793590e into apache:main Aug 19, 2024
34 checks passed
@paleolimbot paleolimbot deleted the fix-hpp-next branch August 19, 2024 17:37
@paleolimbot paleolimbot added this to the nanoarrow 0.6.0 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
nanoarrow 0.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@paleolimbot