-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Separate implementation from interface for nanoarrow_testing component #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paleolimbot
force-pushed
the
testing-runtime-lib
branch
from
July 26, 2024 14:42
24ced8b
to
096de2f
Compare
bkietz
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; straightforward extraction of a testing module.
paleolimbot
added a commit
that referenced
this pull request
Aug 5, 2024
After #561 , the nanoarrow_testing library is no longer header-only and requires linking!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
nanoarrow_testing
as a target instead of a (massive) header-only C++ implementation. This was suggested multiple times by multiple reviewers and makes it possible to add more testing utilities without further bloating a massive implementation/source mishmash. It also makes it more clear how to actually use the testing utilities because the header file is easier to skim (and doxygen no longer chokes on the header, which had previously resulted in these utilities not making it into the documentation builld!). Another advantage of this is removingnlohmann/json.hpp
from the public header (i.e., a build-time only dependency).The general pattern of
testing/testint.cc
is: