Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Split ArrowArray and ArrowArrayStream modules #559

Merged
merged 7 commits into from
Jul 20, 2024

Conversation

paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented Jul 17, 2024

This is the final splitting of modules from _lib.pyx, which no longer exists! It separates the array stream and array components to live in separate .pyx files and adds basic docstrings to internal functions. It also removes a few references to _lib and c_lib that had made it through to this PR.

@paleolimbot paleolimbot marked this pull request as ready for review July 18, 2024 20:03
Copy link
Member

@danepitkin danepitkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Nice work!

@paleolimbot paleolimbot merged commit d6368d0 into apache:main Jul 20, 2024
24 checks passed
@paleolimbot paleolimbot deleted the python-split-array-stream branch July 22, 2024 19:25
@paleolimbot paleolimbot added this to the nanoarrow 0.6.0 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants