test: test with the HalfFloatType from arrow

[cocoa-xu]

Hi this PR adds an extra test case that tests ArrowFloatToHalfFloat and ArrowArrayViewGet{Double,Int,UInt}Unsafe with the HalfFloatType from arrow.

https://github.com/apache/arrow/blob/255dbf990c3d3e5fb1270a2a11efe0af2be195ab/cpp/src/arrow/type.h#L704-L713

And sorry that I didn't know there's a HalfFloatType in arrow-cpp when I was doing #501 🥲.

Sadly that we cannot simply append TestGetFromNumericArrayView<HalfFloatType>(); at the end of the ArrayViewTestGetNumeric test suite because we have to convert floats to half-floats using ArrowFloatToHalfFloat before calling builder.Append (otherwise we'll get weird values back in the subsequent ArrowArrayViewGet{Double,Int,UInt}Unsafe calls).

Added some simple C++ magic and we can simply append TestGetFromNumericArrayView<HalfFloatType>(); at the end of the ArrayViewTestGetNumeric test suite now.

[paleolimbot]

Thank you!

I think the repetition is OK...we have a lot of repetition in our tests and while it would be good to go through and reduce that where possible, I prefer getting the test coverage there first.

There is also a few places this could be enabled in the integration tests if you have the bandwidth (no pressure!). (This can also be another PR if you prefer)

arrow-nanoarrow/src/nanoarrow/nanoarrow_testing.hpp

Lines 807 to 819 in 5dc4aee

	case NANOARROW_TYPE_FLOAT:
	case NANOARROW_TYPE_DOUBLE: {
	// JSON number to float_precision_ decimal places
	LocalizedStream local_stream_opt(out);
	local_stream_opt.SetFixed(float_precision_);
	WriteFloatMaybeNull(out, value, 0);
	for (int64_t i = 1; i < value->length; i++) {
	out << ", ";
	WriteFloatMaybeNull(out, value, i);
	}
	break;
	}

arrow-nanoarrow/src/nanoarrow/nanoarrow_testing.hpp

Lines 807 to 819 in 5dc4aee

	case NANOARROW_TYPE_FLOAT:
	case NANOARROW_TYPE_DOUBLE: {
	// JSON number to float_precision_ decimal places
	LocalizedStream local_stream_opt(out);
	local_stream_opt.SetFixed(float_precision_);
	WriteFloatMaybeNull(out, value, 0);
	for (int64_t i = 1; i < value->length; i++) {
	out << ", ";
	WriteFloatMaybeNull(out, value, i);
	}
	break;
	}

arrow-nanoarrow/src/nanoarrow/nanoarrow_testing.hpp

Lines 2149 to 2152 in 5dc4aee

	case NANOARROW_TYPE_FLOAT:
	return SetBufferFloatingPoint<float>(data, buffer, error);
	case NANOARROW_TYPE_DOUBLE:
	return SetBufferFloatingPoint<double>(data, buffer, error);

[cocoa-xu]

and reduce that where possible

Not a problem, I added a helper function and it should look better now. :)

There is also a few places this could be enabled in the integration tests if you have the bandwidth (no pressure!)

It's done now ;)

[paleolimbot]

Thank you!