Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(r): fix source links from pkgdown site #315

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Nov 12, 2023

Since the R package is in a subdirectory, I believe this setting is necessary to ensure that the links to the source files are generated correctly.

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (798a1b8) to head (5d45af3).
Report is 283 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
- Coverage   88.23%   86.97%   -1.27%     
==========================================
  Files           3       67      +64     
  Lines         357    10217    +9860     
==========================================
+ Hits          315     8886    +8571     
- Misses         42     1331    +1289     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paleolimbot
Copy link
Member

Thank you!

@paleolimbot paleolimbot merged commit 032cdd9 into apache:main Nov 13, 2023
13 checks passed
@eitsupi eitsupi deleted the fix-pkgdown-link branch November 13, 2023 22:32
paleolimbot pushed a commit to apache/arrow-adbc that referenced this pull request Jan 5, 2024
Same as apache/arrow-nanoarrow#315

Since the R package is in a subdirectory, I believe this setting is
necessary to ensure that the links to the source files are generated
correctly.
@paleolimbot paleolimbot added this to the nanoarrow 0.4.0 milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants