feat: Add enum ArrowType buffer_data_type
member to struct ArrowLayout
#207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
enum ArrowBufferType
is useful to switch on for some things and theelement_size_bits
is useful for calculating byte offsets; however, the combination of those is still not sufficient to do endian-swapping as each Arrow type has its own rules. This concept has also come up when printing buffers in the R package and when exporting in Python via the buffer protocol, both of which had their own workarounds. Attaching a reasonableArrowType
to each buffer should provide a generic route to solving all of those.