feat: Add enum ArrowType buffer_data_type member to struct ArrowLayout
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #207 +/- ##
==========================================
+ Coverage 87.90% 87.93% +0.02%
==========================================
Files 60 60
Lines 9114 9164 +50
==========================================
+ Hits 8012 8058 +46
- Misses 1102 1106 +4
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lidavidm
approved these changes
May 30, 2023
paleolimbot
added a commit
that referenced
this pull request
May 31, 2023
After #207, buffer data types are readily available. Before, the R bindings did most of this on their own to get debug buffer printing. This PR exploits the new feature to improve debug output and adds the ability to convert buffers into R vectors along the way. Before this PR: ``` r library(nanoarrow) as_nanoarrow_array(c(NA, stringr::words)) #> <nanoarrow_array string[981]> #> $ length : int 981 #> $ null_count: int 1 #> $ offset : int 0 #> $ buffers :List of 3 #> ..$ :<nanoarrow_buffer_validity[123 b] at 0x13b71d8d0> #> ..$ :<nanoarrow_buffer_data_offset32[3928 b] at 0x13d87b600> #> ..$ :<nanoarrow_buffer_data_utf8[5126 b] at 0x13d87c600> #> $ dictionary: NULL #> $ children : list() ``` <sup>Created on 2023-05-30 with [reprex v2.0.2](https://reprex.tidyverse.org)</sup> After this PR: ``` r library(nanoarrow) as_nanoarrow_array(c(NA, stringr::words)) #> <nanoarrow_array string[981]> #> $ length : int 981 #> $ null_count: int 1 #> $ offset : int 0 #> $ buffers :List of 3 #> ..$ :<nanoarrow_buffer validity<bool>[984][123 b]> `FALSE TRUE TRUE TRUE T...` #> ..$ :<nanoarrow_buffer data_offset<int32>[982][3928 b]> `0 0 1 5 10 18 24 ...` #> ..$ :<nanoarrow_buffer data<string>[5126 b]> `aableaboutabsoluteacceptacco...` #> $ dictionary: NULL #> $ children : list() ``` <sup>Created on 2023-05-30 with [reprex v2.0.2](https://reprex.tidyverse.org)</sup>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
enum ArrowBufferTypeis useful to switch on for some things and theelement_size_bitsis useful for calculating byte offsets; however, the combination of those is still not sufficient to do endian-swapping as each Arrow type has its own rules. This concept has also come up when printing buffers in the R package and when exporting in Python via the buffer protocol, both of which had their own workarounds. Attaching a reasonableArrowTypeto each buffer should provide a generic route to solving all of those.