Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Explicit stringsAsFactors = FALSE for R <= 3.6 #135

Merged
merged 14 commits into from
Mar 1, 2023

Conversation

paleolimbot
Copy link
Member

Closes #131.

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Merging #135 (a64dd3a) into main (b696163) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   92.91%   92.97%   +0.05%     
==========================================
  Files           7        7              
  Lines        1652     1666      +14     
  Branches       52       52              
==========================================
+ Hits         1535     1549      +14     
  Misses         84       84              
  Partials       33       33              
Impacted Files Coverage Δ
src/nanoarrow/schema.c 93.79% <100.00%> (+0.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paleolimbot paleolimbot merged commit 9447c63 into apache:main Mar 1, 2023
@paleolimbot paleolimbot deleted the factors-strings-strikes-again branch March 1, 2023 13:45
paleolimbot added a commit that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[R] Checking package on R 3.6 results in test failures
2 participants