-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): Python schema, array, and array view skeleton #117
Merged
Merged
Changes from 45 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
879d75e
maybe schema class
paleolimbot cff939d
remove pxds
paleolimbot 73eb934
generate the nanoarrow pxd file
paleolimbot 6153916
completely invalid but working towards ideal setup.py
paleolimbot 1637afe
still invalid but better setup.py
paleolimbot 1b38e9e
actually working bootstrap setup
paleolimbot ca191e7
fix indentation
paleolimbot 891afb1
add some typedefs
paleolimbot 26581a5
no void()
paleolimbot 8531234
try without namespace
paleolimbot 1bb020f
better functionr regex
paleolimbot 368ecbe
move some bits from the other repo
paleolimbot 5d0a500
with recursiveness
paleolimbot a83e2e9
passing buffer protocol test
paleolimbot 18f1a20
maybe fix errors
paleolimbot 0cc14b8
don't run bootstrap when installing from sdist
paleolimbot 9e72b96
make sure we can install from sdist
paleolimbot 2cd5599
remove redundant cdefs
paleolimbot 0144afe
fix asserts
paleolimbot b768724
maybe safer version check
paleolimbot 846c837
drop C class prefix, drop numpy dependency, pythonize quotes
paleolimbot ac304af
more complete schema field wrapping
paleolimbot 05d4a81
test a few more array view things
paleolimbot bbf18df
maybe install on Windows, update install instructions
paleolimbot 085b82a
Empty -> empty
paleolimbot a4d0490
nogil
paleolimbot 55dcdb4
add buffer data types to properly set format
paleolimbot 984ea76
add dictionary member
paleolimbot fc0a7dc
more buffer info
paleolimbot 33dcbe7
test buffer access with numpy
paleolimbot 280193b
format with black
paleolimbot 97df28e
some helpers
paleolimbot d7fd6e1
rename version
paleolimbot 5c02647
start on stream
paleolimbot ed5e545
some array stream madness
paleolimbot 1321545
some tidying
paleolimbot c1c2df2
more documentation
paleolimbot ee4dbb6
empty -> allocate
paleolimbot 4bb8f86
in theory use nanoarrowexcpetion
paleolimbot 1d3d8c1
attempt starting coverage
paleolimbot 3d03cc6
attempt starting coverage again
paleolimbot 3413af1
remove coverage file
paleolimbot 4f8cef2
add coverage to python job
paleolimbot f6be55c
fix + test doctests from Cython
paleolimbot ce3463f
basic readme
paleolimbot 78cd797
Update python/nanoarrow/_lib.pyx
paleolimbot dc7d91c
use the namespace
paleolimbot a1150dd
use cinit instead of init
paleolimbot b73804c
clean up Cython
paleolimbot a5d4479
use StopIteration
paleolimbot 6a82504
more clear distinction from the array--array view interaction
paleolimbot 6f530e8
fix doctest
paleolimbot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
# .coveragerc to control coverage.py | ||
[run] | ||
plugins = Cython.Coverage |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
exclude bootstrap.py | ||
include nanoarrow/nanoarrow.c | ||
include nanoarrow/nanoarrow.h | ||
include nanoarrow/nanoarrow_c.pxd |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? (it was already installed in two steps above?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's installed without
-e
above (maybe I'll just add it there, and maybe also addpytest-cython
to pyproject.toml while I'm at it).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the pytest-cython need the package to be installed in editable mode? (I would expect it to work with the installed package as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locally, yes. I've found it to be rather finicky (but useful enough to play along with for now 🤷 ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, we use this package in Arrow CI with a normal install of pyarrow (non-editable), so I think it should certainly work. What you might have noticed locally is that a test didn't pass after updating it if you didn't re-install it? (that's the reason for locally using editable, so you don't have to reinstall after every tiny change. But on CI that doesn't matter)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update this...there are many things that could have been wrong with my local setup!