Fix UB

apache · Sep 4, 2024 · 7a28a45 · 7a28a45
1 parent f83b2e9
commit 7a28a45
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/nanoarrow/common/inline_buffer.h b/src/nanoarrow/common/inline_buffer.h
@@ -289,12 +289,12 @@ static inline ArrowErrorCode ArrowBufferAppendBufferView(struct ArrowBuffer* buf
 
 static inline ArrowErrorCode ArrowBufferAppendFill(struct ArrowBuffer* buffer,
                                                    uint8_t value, int64_t size_bytes) {
-  NANOARROW_RETURN_NOT_OK(ArrowBufferReserve(buffer, size_bytes));
-
   if (size_bytes == 0) {
     return NANOARROW_OK;
   }
 
+  NANOARROW_RETURN_NOT_OK(ArrowBufferReserve(buffer, size_bytes));
+
   memset(buffer->data + buffer->size_bytes, value, size_bytes);
   buffer->size_bytes += size_bytes;
   return NANOARROW_OK;