Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-20: Add CONTRIBUTING.md #162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zeroshade
Copy link
Member

Fixes #20

@zeroshade zeroshade requested a review from kou October 17, 2024 18:21
your GitHub account, navigate to [GitHub issues](https://github.com/apache/arrow-go/issues)
and click on **New issue** .

To be assigned to an issue, add a comment "take" to that issue.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have this feature in apache/arrow-go.
Do we need this? If we need this, we need to port https://github.com/apache/arrow/blob/0c3206772051c52fe2e648623daaca2c4e71cb72/.github/workflows/comment_bot.yml#L178-L194 to apache/arrow-go.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be a good idea for us to port that, it's likely useful

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Let's port it: GH-168

CONTRIBUTING.md Show resolved Hide resolved
## Do you want to propose a significant new feature or an important refactoring?

We ask that all discussions about major changes in the codebase happen
publicly on the [arrow-dev mailing-list](https://mail-archives.apache.org/mod_mbox/arrow-dev/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://arrow.apache.org/community/#mailing-lists may be better because it has a bit more description.

Comment on lines +42 to +45
We'll ask you to prefix the pull request title with the GitHub issue number
and the component name in brackets. (for example: "GH-100: [Parquet]
fix panic in record read"). Respecting this convention
makes it easier for us to process the backlog of submitted Pull Requests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can stop this convention if we want. I think that this convention is to associate Jira issue easily.
We can use Fixes #XXX PR description in GitHub instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be more than willing to update to instead use conventional commits and then I can update the automation to auto generate the semantic versioning from the conventional commit messages. Thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like ADBC does, right?
It's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CONTRIBUTING.md
2 participants