fix(c/driver_manager): More robust error reporting for errors that occur before AdbcDatabaseInit() #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
Oct 21, 2024
Comment on lines
108
to
110
| struct AdbcError error { | ||
| ADBC_ERROR_INIT | ||
| }; |
There was a problem hiding this comment.
huh, the formatter wants this? This threw me for a loop since I would've expected struct AdbcError error{ADBC_ERROR_INIT} or struct AdbcError error = ADBC_ERROR_INIT. Though ultimately it's not a big deal.
There was a problem hiding this comment.
I guess so...I'm pretty sure I wrote struct AdbcError error{ADBC_ERROR_INIT}!
There was a problem hiding this comment.
ah I'm guessing it's ambiguous to the formatter since without parsing out the types and expanding the macro you can't tell if that's a struct declaration or a field declaration
There was a problem hiding this comment.
...except never mind, the field name is right there so ...??? anyways it seems = is better to the formatter!
WillAyd
approved these changes
Oct 22, 2024
lidavidm
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2264.