chore(ci): fix wheel builds #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
force-pushed
the
gh-1610
branch
4 times, most recently
from
d958f4e
to
6fdb558
Compare
- Update versions to match upstream - Add 3.8 support since upstream uses 3.8 as the base - Adjust CI to test both 3.8 and 3.12 Fixes apache#1610.
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
|
FWIW you could also have instructed cibuildwheel to not build a wheel for 3.8 (eg through env variable like (we should soon drop support for Python 3.8 upstream as well IMO) |
|
When I poked it locally, cibuildwheel was fine but the steps after that weren't 3.8 looks to go out of support soon-ish anyways, yeah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1610.