chore(r/adbcpostgresql): Improve configure script using pg_config #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
Nov 8, 2023
paleolimbot
added a commit
to paleolimbot/arrow-adbc
that referenced
this pull request
Nov 9, 2023
…ache#1271) Closes apache#1268. The configure script now falls back on `pg_config`. Barring an intervention like setting the PKG_CONFIG_PATH in advance, this method gets used on MacOS M1 (libpq installed via homebrew) and archlinux. I also checked recent ubuntu, fedora, and alpine, all of which appear to use pkg-config to pick up the include/libs location.
vleslief-ms
pushed a commit
to vleslief-ms/arrow-adbc
that referenced
this pull request
Nov 9, 2023
…ache#1271) Closes apache#1268. The configure script now falls back on `pg_config`. Barring an intervention like setting the PKG_CONFIG_PATH in advance, this method gets used on MacOS M1 (libpq installed via homebrew) and archlinux. I also checked recent ubuntu, fedora, and alpine, all of which appear to use pkg-config to pick up the include/libs location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1268.
The configure script now falls back on
pg_config. Barring an intervention like setting the PKG_CONFIG_PATH in advance, this method gets used on MacOS M1 (libpq installed via homebrew) and archlinux. I also checked recent ubuntu, fedora, and alpine, all of which appear to use pkg-config to pick up the include/libs location.