Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: are Postgres transactions supported or not? #1905

Closed
SebAlbert opened this issue Jun 5, 2024 · 5 comments · Fixed by #1920
Closed

docs: are Postgres transactions supported or not? #1905

SebAlbert opened this issue Jun 5, 2024 · 5 comments · Fixed by #1920
Labels
Type: question Usage question

Comments

@SebAlbert
Copy link

What would you like help with?

I am considering to use ADBC and unsure as to whether transactions are supported with Postgres or not.
This page says N (nope): https://arrow.apache.org/adbc/current/driver/status.html#feature-support
This page explicitly states the opposite: https://arrow.apache.org/adbc/current/driver/postgresql.html#transactions

@SebAlbert SebAlbert added the Type: question Usage question label Jun 5, 2024
@CurtHagenlocher
Copy link
Contributor

CurtHagenlocher commented Jun 5, 2024

Transactions are supported via the autocommit connection option (adbc.connection.autocommit). Isolation levels do not appear to be supported.

Source reference

@lidavidm
Copy link
Member

lidavidm commented Jun 6, 2024

We need to update the docs here, sorry about the confusion.

@lidavidm lidavidm added this to the ADBC Libraries 13 milestone Jun 6, 2024
@SebAlbert
Copy link
Author

Thanks!

Regarding isolation levels, I don't see a reason in that code why they wouldn't be respected when I set them via SQL commands.

@lidavidm
Copy link
Member

lidavidm commented Jun 6, 2024

Correct, we don't really do anything one way or another, just that there are some standard options from the driver side meant to set them that the PostgreSQL driver does not recognize. If you directly set them via SQL the driver does not care either way. (This does not necessarily apply to transactions themselves, the driver may need to start/commit transactions at certain points for certain functionality so managing transactions yourself may lead to unexpected errors.)

@lidavidm
Copy link
Member

Ah interesting, the actual problem is that the docs for 1.0.0 didn't upload properly...

lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Jun 14, 2024
lidavidm added a commit that referenced this issue Jun 17, 2024
Fixes #1905.

---------

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: question Usage question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants