Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hmac-auth): don't let client know why it is rejected #6853

Merged
merged 2 commits into from
Apr 17, 2022
Merged

fix(hmac-auth): don't let client know why it is rejected #6853

merged 2 commits into from
Apr 17, 2022

Conversation

spacewander
Copy link
Member

Signed-off-by: spacewander spacewanderlzx@gmail.com

Description

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@spacewander
fix(hmac-auth): don't let client know why it is rejected
f530f1a 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review April 15, 2022 03:14
bzp2010
bzp2010 previously approved these changes Apr 15, 2022
View reviewed changes
tzssangglass
tzssangglass previously approved these changes Apr 15, 2022
View reviewed changes
@spacewander
also handle custom_hmac_auth.t
ff9a1ae 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander dismissed stale reviews from tzssangglass and bzp2010 via ff9a1ae April 15, 2022 06:15
@spacewander spacewander merged commit 605c2c4 into apache:master Apr 17, 2022
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request May 20, 2022
@spacewander @Liu-Junlin
fix(hmac-auth): don't let client know why it is rejected (apache#6853)
deb4a52 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander added a commit to spacewander/incubator-apisix that referenced this pull request May 27, 2022
@spacewander
fix(hmac-auth): don't let client know why it is rejected (apache#6853)
c20e80a 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander added a commit to spacewander/incubator-apisix that referenced this pull request May 29, 2022
@spacewander
fix(hmac-auth): don't let client know why it is rejected (apache#6853)
99e1250 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander added a commit that referenced this pull request May 29, 2022
@spacewander
fix(hmac-auth): don't let client know why it is rejected (#6853)
b3d6e5a 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@tao12345666333 tao12345666333 mentioned this pull request Jun 6, 2022
Closed
8 tasks
spacewander added a commit that referenced this pull request Jun 30, 2022
@spacewander
fix(hmac-auth): don't let client know why it is rejected (#6853)
3f43598 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzssangglass tzssangglass tzssangglass approved these changes

@leslie-tsang leslie-tsang leslie-tsang approved these changes

@bzp2010 bzp2010 bzp2010 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spacewander @bzp2010 @tzssangglass @leslie-tsang