Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add delayed_body_filter phase #6605

Merged
merged 1 commit into from
Mar 15, 2022
Merged

feat: add delayed_body_filter phase #6605

merged 1 commit into from
Mar 15, 2022

Conversation

spacewander
Copy link
Member

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Fix #6601

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
feat: add delayed_body_filter phase
11dfb33 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review March 14, 2022 08:02
@tzssangglass
Copy link
Member

Doesn't this PR modify some tracing plugins to run delayed_body_filter phase?

@spacewander
Copy link
Member Author

Doesn't this PR modify some tracing plugins to run delayed_body_filter phase?

Yes. But if I do it, this PR will be too big (almost 300 lines).

@tzssangglass
Copy link
Member

Doesn't this PR modify some tracing plugins to run delayed_body_filter phase?

Yes. But if I do it, this PR will be too big (almost 300 lines).

got

@spacewander spacewander merged commit 9386de9 into apache:master Mar 15, 2022
@spacewander spacewander deleted the dbf branch March 15, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzssangglass tzssangglass tzssangglass approved these changes

@shuaijinchao shuaijinchao shuaijinchao approved these changes

@bzp2010 bzp2010 Awaiting requested review from bzp2010

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: As a User, I want to add delayed_body_filter so that run tracing code both in the first and in the last
3 participants
@spacewander @tzssangglass @shuaijinchao