chore: streamline error checking process #6103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bisakhmondal
force-pushed
the
chore/error/check
branch
from
6207cd0 to
105fabf
Compare
spacewander
reviewed
Jan 15, 2022
apisix/plugins/openid-connect.lua
Outdated
| @@ -293,30 +293,28 @@ function _M.rewrite(plugin_conf, ctx) | |||
| -- the configured redirect URI after successful authentication. | |||
| response, err = openidc.authenticate(conf) | |||
|
|
|||
| if err then | |||
| if not response then | |||
There was a problem hiding this comment.
the openidc returns non-nil err to indicate something wrong, see:
https://github.com/zmartzone/lua-resty-openidc#sample-configuration-for-google-signin
https://github.com/zmartzone/lua-resty-openidc/blob/master/lib/resty/openidc.lua#L1494
t/plugin/basic-auth.t
Outdated
| @@ -398,7 +398,7 @@ GET /t | |||
|
|
|||
|
|
|||
|
|
|||
| === TEST 15: enable basic auth plugin using admin api, set hide_credentials = true | |||
| === TEST 18: enable basic auth plugin using admin api, set hide_credentials = true | |||
There was a problem hiding this comment.
Need to fetch the latest code for the master branch, which has been fixed.
Signed-off-by: Bisakh Mondal <bisakhmondal00@gmail.com>
bisakhmondal
force-pushed
the
chore/error/check
branch
from
105fabf to
a930d3e
Compare
tzssangglass
approved these changes
Jan 15, 2022
spacewander
approved these changes
Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bisakh Mondal bisakhmondal00@gmail.com
What this PR does / why we need it:
#6037 (comment)
Pre-submission checklist: