-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kafka-logger): supports logging request body #5501
Changes from 6 commits
613c19e
acb54e3
fb04109
d922ffd
3e867ea
f691471
d82854c
a017631
7ea1b17
d31a5ab
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -74,6 +74,15 @@ local schema = { | |||||||||||||||||||||||||||||||||||||||
inactive_timeout = {type = "integer", minimum = 1, default = 5}, | ||||||||||||||||||||||||||||||||||||||||
batch_max_size = {type = "integer", minimum = 1, default = 1000}, | ||||||||||||||||||||||||||||||||||||||||
include_req_body = {type = "boolean", default = false}, | ||||||||||||||||||||||||||||||||||||||||
include_req_body_expr = { | ||||||||||||||||||||||||||||||||||||||||
type = "array", | ||||||||||||||||||||||||||||||||||||||||
items = { | ||||||||||||||||||||||||||||||||||||||||
type = "array", | ||||||||||||||||||||||||||||||||||||||||
items = { | ||||||||||||||||||||||||||||||||||||||||
type = "string" | ||||||||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||||||||
}, | ||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||||||||||||||||||||
-- in lua-resty-kafka, cluster_name is defined as number | ||||||||||||||||||||||||||||||||||||||||
-- see https://github.com/doujiang24/lua-resty-kafka#new-1 | ||||||||||||||||||||||||||||||||||||||||
cluster_name = {type = "integer", minimum = 1, default = 1}, | ||||||||||||||||||||||||||||||||||||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -57,6 +57,7 @@ For more info on Batch-Processor in Apache APISIX please refer. | |||||
| max_retry_count | integer | optional | 0 | [0,...] | Maximum number of retries before removing from the processing pipe line. | | ||||||
| retry_delay | integer | optional | 1 | [0,...] | Number of seconds the process execution should be delayed if the execution fails. | | ||||||
| include_req_body | boolean | optional | false | [false, true] | Whether to include the request body. false: indicates that the requested body is not included; true: indicates that the requested body is included. | | ||||||
| include_req_body_expr | array | optional | | | Whether to logging request body,based on [lua-resty-expr](https://github.com/api7/lua-resty-expr), this option require to turn on `include_req_body` option. | | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| cluster_name | integer | optional | 1 | [0,...] | the name of the cluster. When there are two or more kafka clusters, you can specify different names. And this only works with async producer_type.| | ||||||
|
||||||
### examples of meta_format | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -57,6 +57,7 @@ title: kafka-logger | |||||
| max_retry_count | integer | 可选 | 0 | [0,...] | 从处理管道中移除之前的最大重试次数。 | | ||||||
| retry_delay | integer | 可选 | 1 | [0,...] | 如果执行失败,则应延迟执行流程的秒数。 | | ||||||
| include_req_body | boolean | 可选 | false | [false, true] | 是否包括请求 body。false: 表示不包含请求的 body ; true: 表示包含请求的 body 。| | ||||||
| include_req_body_expr | array | 可选 | | | 是否采集请求body,基于[lua-resty-expr](https://github.com/api7/lua-resty-expr)。 该选项需要开启 `include_req_body`| | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| cluster_name | integer | 可选 | 1 | [0,...] | kafka 集群的名称。当有两个或多个 kafka 集群时,可以指定不同的名称。只适用于 producer_type 是 async 模式。| | ||||||
|
||||||
### meta_format 参考示例 | ||||||
|
Original file line number | Diff line number | Diff line change | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -1114,3 +1114,80 @@ GET /t | |||||||||||||||||||
--- error_log_like eval | ||||||||||||||||||||
qr/create new kafka producer instance, brokers: \[\{"port":9092,"host":"127.0.0.127"}]/ | ||||||||||||||||||||
qr/failed to send data to Kafka topic: .*, brokers: \{"127.0.0.127":9092}/ | ||||||||||||||||||||
|
||||||||||||||||||||
|
||||||||||||||||||||
|
||||||||||||||||||||
=== TEST 26: set route(id: 1,include_req_body = true,include_req_body_expr = array) | ||||||||||||||||||||
--- config | ||||||||||||||||||||
location /t { | ||||||||||||||||||||
content_by_lua_block { | ||||||||||||||||||||
local t = require("lib.test_admin").test | ||||||||||||||||||||
local code, body = t('/apisix/admin/routes/1', | ||||||||||||||||||||
ngx.HTTP_PUT, | ||||||||||||||||||||
[[{ | ||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||
"plugins": { | ||||||||||||||||||||
"kafka-logger": { | ||||||||||||||||||||
"broker_list" : | ||||||||||||||||||||
{ | ||||||||||||||||||||
"127.0.0.1":9092 | ||||||||||||||||||||
}, | ||||||||||||||||||||
"kafka_topic" : "test2", | ||||||||||||||||||||
"key" : "key1", | ||||||||||||||||||||
"timeout" : 1, | ||||||||||||||||||||
"include_req_body": true, | ||||||||||||||||||||
"include_req_body_expr": [ | ||||||||||||||||||||
[ | ||||||||||||||||||||
"arg_name", | ||||||||||||||||||||
"==", | ||||||||||||||||||||
"qwerty" | ||||||||||||||||||||
] | ||||||||||||||||||||
], | ||||||||||||||||||||
"batch_max_size": 1 | ||||||||||||||||||||
} | ||||||||||||||||||||
}, | ||||||||||||||||||||
"upstream": { | ||||||||||||||||||||
"nodes": { | ||||||||||||||||||||
"127.0.0.1:1980": 1 | ||||||||||||||||||||
}, | ||||||||||||||||||||
"type": "roundrobin" | ||||||||||||||||||||
}, | ||||||||||||||||||||
"uri": "/hello" | ||||||||||||||||||||
}]] | ||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||
) | ||||||||||||||||||||
if code >= 300 then | ||||||||||||||||||||
ngx.status = code | ||||||||||||||||||||
end | ||||||||||||||||||||
ngx.say(body) | ||||||||||||||||||||
} | ||||||||||||||||||||
} | ||||||||||||||||||||
|
||||||||||||||||||||
--- request | ||||||||||||||||||||
GET /t | ||||||||||||||||||||
--- response_body | ||||||||||||||||||||
passed | ||||||||||||||||||||
--- no_error_log | ||||||||||||||||||||
[error] | ||||||||||||||||||||
|
||||||||||||||||||||
|
||||||||||||||||||||
=== TEST 27: hit route, expr eval success | ||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i forgot lint before push, sorry~ |
||||||||||||||||||||
--- request | ||||||||||||||||||||
POST /hello?name=qwerty | ||||||||||||||||||||
abcdef | ||||||||||||||||||||
--- response_body | ||||||||||||||||||||
hello world | ||||||||||||||||||||
--- no_error_log | ||||||||||||||||||||
[error] | ||||||||||||||||||||
--- error_log eval | ||||||||||||||||||||
qr/send data to kafka: \{.*"body":"abcdef"/ | ||||||||||||||||||||
--- wait: 2 | ||||||||||||||||||||
|
||||||||||||||||||||
|
||||||||||||||||||||
=== TEST 28: hit route,expr eval fail | ||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||
--- request | ||||||||||||||||||||
POST /hello?name=zcxv | ||||||||||||||||||||
abcdef | ||||||||||||||||||||
--- response_body | ||||||||||||||||||||
hello world | ||||||||||||||||||||
--- no_error_log eval | ||||||||||||||||||||
qr/send data to kafka: \{.*"body":"abcdef"/ | ||||||||||||||||||||
--- wait: 2 | ||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Duplicate There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we can merge it, could you add a check for the expr in the
check_schema
? Like:apisix/apisix/plugins/response-rewrite.lua
Line 111 in 9b355c6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done