Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(limit-* plugin): fallback to remote_addr when key is missing #5422

Merged
merged 6 commits into from
Nov 7, 2021
Merged

feat(limit-* plugin): fallback to remote_addr when key is missing #5422

merged 6 commits into from
Nov 7, 2021

Conversation

Xunzhuo
Copy link
Contributor

@Xunzhuo Xunzhuo commented Nov 4, 2021 •
edited
Loading

What this PR does / why we need it:

fallback to remote_addr when key is missing or invalid in limit-* plugin

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@Xunzhuo Xunzhuo marked this pull request as ready for review November 5, 2021 01:00
@Xunzhuo Xunzhuo requested a review from spacewander November 5, 2021 02:24
spacewander
spacewander reviewed Nov 5, 2021
View reviewed changes
t/plugin/limit-conn2.t Outdated Show resolved Hide resolved
t/plugin/limit-conn2.t Show resolved Hide resolved
docs/en/latest/plugins/limit-conn.md Outdated Show resolved Hide resolved
apisix/plugins/limit-req.lua Outdated Show resolved Hide resolved
@spacewander spacewander merged commit 0e973fb into apache:master Nov 7, 2021
@Xunzhuo Xunzhuo deleted the feat/fallback-key branch November 7, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokers tokers tokers approved these changes

@spacewander spacewander spacewander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xunzhuo @spacewander @tokers