Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(limit-req): support multiple variables as key #5302

Merged
merged 1 commit into from
Oct 22, 2021
Merged

feat(limit-req): support multiple variables as key #5302

merged 1 commit into from
Oct 22, 2021

Conversation

spacewander
Copy link
Member

@spacewander spacewander commented Oct 21, 2021 •
edited
Loading

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Fix #2448
Fix #5254

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
feat(limit-req): support multiple variables as key
b9d2b42 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review October 21, 2021 10:23
@spacewander spacewander merged commit 2f250d5 into apache:master Oct 22, 2021
@spacewander spacewander deleted the rlr branch October 22, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzssangglass tzssangglass tzssangglass approved these changes

@shuaijinchao shuaijinchao shuaijinchao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apisix needs to support more powerful limit-req chore: limit-req plugin code optimization
3 participants
@spacewander @shuaijinchao @tzssangglass