feat(ext-plugin): implement the http-req-call protocol #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
membphis
reviewed
May 6, 2021
| PROPFIND = a6_method.PROPFIND, | ||
| PROPPATCH = a6_method.PROPPATCH, | ||
| LOCK = a6_method.LOCK, | ||
| UNLOCK = a6_method.UNLOCK, |
There was a problem hiding this comment.
Is this type reserved for the future? If yes, is there any documentation?
There was a problem hiding this comment.
Those fields are copied from https://github.com/openresty/lua-nginx-module#http-method-constants
There was a problem hiding this comment.
got it, many thanks for explaining
membphis
approved these changes
May 6, 2021
tokers
reviewed
May 6, 2021
| local id = lshift(wid, 22) + count | ||
| count = count + 1 | ||
| if count == MAX_COUNT then | ||
| count = 0 |
There was a problem hiding this comment.
Does the id rotate will influence the correctness?
There was a problem hiding this comment.
The id here is only used for logging purpose. In the given time window, it is rare to have two repeated id so we can distinguish them.
tokers
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: spacewander spacewanderlzx@gmail.com
What this PR does / why we need it:
Pre-submission checklist: