Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update example grafana to lastest prometheus support #3402

Merged
merged 1 commit into from
Jan 24, 2021

Conversation

Yiyiyimu
Copy link
Member

@Yiyiyimu Yiyiyimu commented Jan 24, 2021

Signed-off-by: yiyiyimu wosoyoung@gmail.com

What this PR does / why we need it:

Plugin Prometheus have been updated in the last year, but the example grafana dashboard haven't been updated since Feb. 2020. But since I haven't use grafana before, suggestions is highly needed 😿

Added

metric panel type
HTTP Latency/Overhead histogram
etcd reachable stat (alert when 0)
nginx metric errors stat
etcd modify index graph
batch process entries graph

Fixed

  • Set atomic values to 0 decimals
  • Add new variables
  • Fix HTTP code labels syntax error

TODO

  • the title Misc might not appropriate, need suggestions
  • not sure putting etcd modify index of different keys is a good idea
  • the label of HTTP latency/overhead have leading zeros need to be trimmed, but it seems not available in grafana, so need to do so in prometheus
  • after this PR got merged, the official dashboard in grafana website need to be updated, doc

image
image

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
@spacewander spacewander merged commit 1819b6b into apache:master Jan 24, 2021
@Yiyiyimu
Copy link
Member Author

wait...I still have some todo..... 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants