feat: support include other nginx config #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
membphis
reviewed
Nov 23, 2020
| stream_proxy: | ||
| tcp: | ||
| - 9100 | ||
| nginx_config: |
There was a problem hiding this comment.
How about this style? I think one level is enough and it looks simpler.
nginx_config:
main_configuration_snippet: |
daemon on;
http_configuration_snippet: |
chunked_transfer_encoding on;
http_server_configuration_snippet: |
set $my "var";
http_admin_configuration_snippet: |
log_format admin "$request_time $pipe";
stream_configuration_snippet: |
tcp_nodelay off;
membphis
approved these changes
Nov 24, 2020
|
should add some doc to guide users. |
|
Add a reference to https://github.com/apache/apisix/blob/master/doc/README.md . |
|
@membphis |
|
@nic-chen please take a look when you have time |
nic-chen
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2565
Close #1620
What this PR does / why we need it:
Pre-submission checklist: