-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some doc styles for files in doc/ #1475
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juzhiyuan
requested changes
Apr 19, 2020
thx, I' ll check it.
88786912@qq.com
From: 琚致远
Date: 2020-04-19 19:45
To: apache/incubator-apisix
CC: dabue; Author
Subject: Re: [apache/incubator-apisix] fix some doc styles for files in doc/ (#1475)
@juzhiyuan requested changes on this pull request.
In doc/admin-api.md:
@@ -17,8 +17,8 @@
#
-->
+# Table of contents
Please use Contents instead of contents
In doc/router-radixtree.md:
@@ -32,15 +32,15 @@ Let's take a look at a few examples and have an intuitive understanding.
#### 1. Full match
-```
+```uri
URI is not a valid code syntax decorator as I know...
In doc/stream-proxy-cn.md:
@@ -30,7 +30,7 @@ APISIX 可以对 TCP/UDP 协议进行代理并实现动态负载均衡。 在 ng
在 `conf/config.yaml` 配置文件设置 `stream_proxy` 选项, 指定一组需要进行动态代理的IP地址。默认情况不开启stream代理。
-```
+```config
Please check this decorator, too.
In doc/stream-proxy.md:
@@ -30,7 +30,7 @@ APISIX can dynamic load balancing TCP/UDP proxy. In Nginx world, we call TCP/UDP
Setting the `stream_proxy` option in `conf/config.yaml`, specify a list of addresses that require dynamic proxy.
By default, no any stream proxy is enabled.
-```
+```config
,
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I have updated it. |
juzhiyuan
approved these changes
Apr 19, 2020
doc/plugins/limit-count-cn.md
Outdated
@@ -123,7 +123,7 @@ Server: APISIX web server | |||
|
|||
当你第三次访问的时候,就会收到包含 503 返回码的响应头: | |||
|
|||
```console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console
is a valid decorator actually 😂
many thx, merged |
SaberMaster
pushed a commit
to SaberMaster/incubator-apisix
that referenced
this pull request
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix some doc styles by markdownlint
related issue: #1273