fix(ssl): SSL key rotation caused request failure #11305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nic-6443
reviewed
May 30, 2024
nic-6443
previously approved these changes
May 31, 2024
moonming
previously approved these changes
May 31, 2024
membphis
reviewed
May 31, 2024
|
@AlinsRan please make the code linter happy |
|
@AlinsRan why was this issue occuring only after apisix version upgrade? |
@shreemaan-abhishek Because a ssl key rotation occurred. |
AlinsRan
commented
Jun 3, 2024
| @@ -242,7 +242,6 @@ apisix: | |||
| - qeddd145sfvddff3 | |||
| --- error_log | |||
| decrypt ssl key failed | |||
| [alert] | |||
There was a problem hiding this comment.
Because the error generated by decryption has been cleared, ngx will not throw this error.
moonming
approved these changes
Jun 3, 2024
bzp2010
approved these changes
Jun 3, 2024
|
Hi, I'm experiencing this issue as well. Do you have any planned release for this? Thanks! |
|
A new version is expected to be released by the end of July. You can also patch this PR in the previous version first @pfernandes21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the failure to handle the OpenSSL error generated during the AES decryption process, this error was caught by Nginx during the TLS handshake request, resulting in the request failure.
In the scenario of key rotation, due to the attempt to traverse all keys and attempt decryption, the error messages generated earlier should be ignored when decryption is successful.
reference：
Fixes #11148
Checklist