Batch processor implementation to aggregate logs in batch #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@membphis please do have a look. |
membphis
requested changes
Feb 13, 2020
membphis
reviewed
Feb 16, 2020
membphis
reviewed
Feb 18, 2020
membphis
reviewed
Feb 18, 2020
membphis
reviewed
Feb 18, 2020
|
Hi @membphis, all the review comments have been fixed now. |
|
@sshniro please rebase your branch, I updated the tools about checking code style. I think the CI will fail after this PR was merged to |
membphis
approved these changes
Feb 20, 2020
moonming
approved these changes
Feb 20, 2020
|
@sshniro many thx ^_^ |
qiujiayu
pushed a commit
to qiujiayu/incubator-apisix
that referenced
this pull request
Feb 20, 2020
|
Thanks for the pointers @membphis , now I will refactor the UDP logger to use this util. |
qiujiayu
pushed a commit
to qiujiayu/incubator-apisix
that referenced
this pull request
Feb 21, 2020
SaberMaster
pushed a commit
to SaberMaster/incubator-apisix
that referenced
this pull request
Jun 30, 2020
SaberMaster
pushed a commit
to SaberMaster/incubator-apisix
that referenced
this pull request
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1076